[feat] support Xorg & better auth logic #80
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also helps with sanitizing the code flow when spawning the child, more code though
add -Wextra by default pipefd to communicate better with parent and forked process rustify some stuff add the desktop parser to the file read
Owner
Author
|
Just gotta debug why running with valgrind and getting my passwd right SIGPIPES while the same without valgrind doesn' t. |
Owner
Author
|
Literally, omfg, syncing session and X server is painful, whytf does |
leaves a few TODOs: * error handling * properly passing VT around * `wait_for_x_ready` * allow compile-time overriding `DEFAULT_XORG_DISPLAY` and `XORG_COMMAND`
Owner
Author
|
About the last commit:
And also:
|
Collaborator
|
More than half of this PR could've been another one. It isn't really convenient to look through the actual changes when most of the files are just reformatted :( |
Owner
Author
|
Sorry I just did it instinctively 😭 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to:
For now I'm just organizing the
auth.clogic.I also plan to allow sourcing shell files on startup to completely support all possible env. (e.g.
/etc/profile.d/)