feat: surface gcp.credentials_file in init wizard - #41
Merged
Conversation
Adds an optional service account key file prompt to the GCP section of snipemgr init. Validates the path before writing snipemgr.yaml if a value is provided. Writes the field to the generated config whether or not a value is given so the option is self-documenting. Closes #1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
snipemgr initsnipemgr.yaml— clear error if not foundcredentials_file:is always written to the generated config (with inline comment when blank) so the option is self-documentingTest plan
snipemgr init, choose to configure GCP — key file prompt appears after service account emailsnipemgr.yamlwritten withcredentials_file: ""and commentsnipemgr.yamlCloses #1