Skip to content

Support autoparser detection for message barriers#1

Closed
pwilkin wants to merge 0 commit into
jacekpoplawski:fix-checkpoints-creationfrom
pwilkin:fix-checkpoints
Closed

Support autoparser detection for message barriers#1
pwilkin wants to merge 0 commit into
jacekpoplawski:fix-checkpoints-creationfrom
pwilkin:fix-checkpoints

Conversation

@pwilkin

@pwilkin pwilkin commented May 22, 2026

Copy link
Copy Markdown

As in title.

Comment thread common/common.h Outdated

std::string string_strip(const std::string & str);
std::string string_get_sortable_timestamp();
std::string longest_common_substring(std::string_view a, std::string_view b);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
std::string longest_common_substring(std::string_view a, std::string_view b);
std::string string_lcs(std::string_view a, std::string_view b);

@jacekpoplawski

Copy link
Copy Markdown
Owner

Thanks I will try to test it this evening

Comment thread common/chat.cpp Outdated
@jacekpoplawski jacekpoplawski force-pushed the fix-checkpoints-creation branch from 9fed0bd to 5b0553c Compare May 22, 2026 19:54
@pwilkin

pwilkin commented May 23, 2026

Copy link
Copy Markdown
Author

@jacekpoplawski yes, of course, stupid bug :)

@pwilkin

pwilkin commented May 23, 2026

Copy link
Copy Markdown
Author

@jacekpoplawski Can you reopen please? Closed it accidentally :/

Edit: nvm I see all the changes are merged in already

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants