Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1787 +/- ##
==========================================
- Coverage 91.66% 91.66% -0.01%
==========================================
Files 98 98
Lines 19878 19886 +8
==========================================
+ Hits 18222 18229 +7
- Misses 1656 1657 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
📦 Cargo Bloat ComparisonBinary size change: +0.00% (24.7 MiB → 24.7 MiB) Expand for cargo-bloat outputHead Branch ResultsBase Branch Results |
⚡️ Hyperfine BenchmarksSummary: 0 regressions, 0 improvements above the 10% threshold. Environment
CLI CommandsBenchmarking basic commands in the main repo:
|
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base --version |
2.4 ± 0.1 | 2.3 | 2.9 | 1.00 |
prek-head --version |
2.5 ± 0.1 | 2.3 | 2.7 | 1.01 ± 0.06 |
prek list
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base list |
9.3 ± 0.7 | 8.9 | 15.5 | 1.00 |
prek-head list |
9.3 ± 0.2 | 8.9 | 10.3 | 1.00 ± 0.07 |
prek validate-config .pre-commit-config.yaml
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base validate-config .pre-commit-config.yaml |
3.4 ± 1.0 | 3.1 | 10.3 | 1.06 ± 0.32 |
prek-head validate-config .pre-commit-config.yaml |
3.2 ± 0.1 | 3.0 | 3.4 | 1.00 |
prek sample-config
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base sample-config |
2.6 ± 0.0 | 2.5 | 2.7 | 1.00 |
prek-head sample-config |
2.7 ± 0.0 | 2.6 | 2.8 | 1.01 ± 0.02 |
Cold vs Warm Runs
Comparing first run (cold) vs subsequent runs (warm cache):
prek run --all-files (cold - no cache)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run --all-files |
153.5 ± 2.7 | 149.8 | 158.9 | 1.00 |
prek-head run --all-files |
154.7 ± 2.8 | 150.7 | 160.5 | 1.01 ± 0.03 |
prek run --all-files (warm - with cache)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run --all-files |
153.8 ± 2.5 | 149.9 | 158.5 | 1.00 |
prek-head run --all-files |
155.0 ± 3.3 | 150.1 | 162.9 | 1.01 ± 0.03 |
Full Hook Suite
Running the builtin hook suite on the benchmark workspace:
prek run --all-files (full builtin hook suite)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run --all-files |
153.7 ± 2.0 | 150.8 | 158.1 | 1.00 |
prek-head run --all-files |
157.3 ± 24.4 | 150.1 | 325.9 | 1.02 ± 0.16 |
Individual Hook Performance
Benchmarking each hook individually on the test repo:
prek run trailing-whitespace --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run trailing-whitespace --all-files |
23.3 ± 0.4 | 22.4 | 23.9 | 1.02 ± 0.03 |
prek-head run trailing-whitespace --all-files |
22.9 ± 0.6 | 22.0 | 24.5 | 1.00 |
prek run end-of-file-fixer --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run end-of-file-fixer --all-files |
29.8 ± 2.1 | 27.2 | 35.1 | 1.00 |
prek-head run end-of-file-fixer --all-files |
30.5 ± 2.3 | 26.5 | 35.5 | 1.02 ± 0.11 |
prek run check-json --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-json --all-files |
13.5 ± 0.5 | 12.3 | 14.6 | 1.05 ± 0.05 |
prek-head run check-json --all-files |
12.8 ± 0.4 | 12.3 | 13.7 | 1.00 |
prek run check-yaml --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-yaml --all-files |
12.5 ± 0.3 | 12.0 | 13.4 | 1.00 ± 0.03 |
prek-head run check-yaml --all-files |
12.5 ± 0.3 | 12.0 | 13.1 | 1.00 |
prek run check-toml --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-toml --all-files |
12.8 ± 0.3 | 12.1 | 13.5 | 1.00 ± 0.04 |
prek-head run check-toml --all-files |
12.8 ± 0.4 | 12.2 | 13.7 | 1.00 |
prek run check-xml --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-xml --all-files |
12.8 ± 0.4 | 12.1 | 13.7 | 1.00 |
prek-head run check-xml --all-files |
12.9 ± 0.4 | 12.2 | 13.7 | 1.01 ± 0.05 |
Installation Performance
Benchmarking hook installation (fast path hooks skip Python setup):
prek install-hooks (cold - no cache)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base install-hooks |
5.1 ± 0.1 | 4.9 | 5.3 | 1.00 ± 0.04 |
prek-head install-hooks |
5.1 ± 0.2 | 4.9 | 5.3 | 1.00 |
prek install-hooks (warm - with cache)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base install-hooks |
5.0 ± 0.2 | 4.8 | 5.2 | 1.00 |
prek-head install-hooks |
5.1 ± 0.1 | 5.0 | 5.3 | 1.02 ± 0.05 |
File Filtering/Scoping Performance
Testing different file selection modes:
prek run (staged files only)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run |
19.5 ± 0.3 | 19.1 | 20.2 | 1.01 ± 0.02 |
prek-head run |
19.2 ± 0.2 | 18.9 | 19.8 | 1.00 |
prek run --files '*.json' (specific file type)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run --files '*.json' |
7.9 ± 0.3 | 7.6 | 9.0 | 1.03 ± 0.04 |
prek-head run --files '*.json' |
7.6 ± 0.1 | 7.4 | 7.9 | 1.00 |
Workspace Discovery & Initialization
Benchmarking hook discovery and initialization overhead:
prek run --dry-run --all-files (measures init overhead)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run --dry-run --all-files |
12.9 ± 0.3 | 12.6 | 14.1 | 1.00 |
prek-head run --dry-run --all-files |
12.9 ± 0.3 | 12.4 | 13.8 | 1.00 ± 0.04 |
Meta Hooks Performance
Benchmarking meta hooks separately:
prek run check-hooks-apply --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-hooks-apply --all-files |
14.6 ± 0.2 | 14.3 | 15.1 | 1.00 |
prek-head run check-hooks-apply --all-files |
14.7 ± 0.2 | 14.4 | 15.3 | 1.01 ± 0.02 |
prek run check-useless-excludes --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-useless-excludes --all-files |
13.7 ± 0.9 | 12.6 | 14.7 | 1.06 ± 0.07 |
prek-head run check-useless-excludes --all-files |
12.9 ± 0.3 | 12.7 | 13.6 | 1.00 |
prek run identity --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run identity --all-files |
11.3 ± 0.1 | 11.1 | 11.5 | 1.00 |
prek-head run identity --all-files |
11.6 ± 0.1 | 11.4 | 11.9 | 1.03 ± 0.02 |
Make
stages: []select no stages instead of all stages.Implements #1785.