Skip to content

SmaCC_Python #filename method is not a right name #25

Description

@jecisc

In the nodes we have the method SmaCCParseNode>>#filename but in my case I have a PyFileNode and this method dois not return the file name but a FileReference from the origin file. This name seems weird to me.

The file reference is what I need so it's good for me. But I think the name of the method is not good and it makes the code more complex.
Personally I added an extension on PyRootNode like this to make my code better:

PyRootNode>>#fileReference
	^ self filename

I'm just reporting this if it can be interesting to improve this in SmaCC directly

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions