fix: implement keyboard navigation and accessibility on canvas#35
fix: implement keyboard navigation and accessibility on canvas#35Babin123456 wants to merge 1 commit into
Conversation
|
Someone is attempting to deploy a commit to the itzzavdhesh's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
✅ Thanks! This PR is linked to #24 and will close it automatically when merged. |
|
Warning Review limit reached
More reviews will be available in 57 minutes and 52 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/components/CenterCanvas.tsx">
<violation number="1" location="src/components/CenterCanvas.tsx:647">
P2: Keyboard selection handler is duplicated across all three node-render branches (decision, io, and default). The same `onKeyDown`, `tabIndex`, `role`, and `aria-label` pattern is repeated identically, creating maintainability and consistency risk.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| key={node.block.id} | ||
| id={`flow-node-${node.block.id}`} | ||
| onClick={() => onSelectBlock(node.block.id)} | ||
| onKeyDown={(e) => { |
There was a problem hiding this comment.
P2: Keyboard selection handler is duplicated across all three node-render branches (decision, io, and default). The same onKeyDown, tabIndex, role, and aria-label pattern is repeated identically, creating maintainability and consistency risk.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At src/components/CenterCanvas.tsx, line 647:
<comment>Keyboard selection handler is duplicated across all three node-render branches (decision, io, and default). The same `onKeyDown`, `tabIndex`, `role`, and `aria-label` pattern is repeated identically, creating maintainability and consistency risk.</comment>
<file context>
@@ -614,13 +644,22 @@ export default function CenterCanvas({
key={node.block.id}
id={`flow-node-${node.block.id}`}
onClick={() => onSelectBlock(node.block.id)}
+ onKeyDown={(e) => {
+ if (e.key === 'Enter' || e.key === ' ') {
+ e.preventDefault();
</file context>
1 participant
Related Issue
Closes #24
Summary
This PR implements keyboard navigation and accessibility features on the flowchart canvas.
Changes Made
handleKeyDowncallback to process panning (Arrow keys), zooming (+/-), and zoom resets (0).tabIndex={0},role="button", and dynamic ARIA descriptions to flowchart blocks.Testing
Screenshots
N/A
Impact
Improves accessibility conformance.
Checklist
Summary by cubic
Adds keyboard navigation and accessibility to the flowchart canvas. Arrow keys pan, +/- zooms, 0 resets; the canvas and nodes are focusable, ARIA-labeled, show clear focus rings, and nodes can be selected with Enter or Space.
Written for commit 7229280. Summary will update on new commits.