Repository navigation
fix(web): keep mention suggestions visible across writing surfaces - #216
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mention completion menus now share a portaled popover and textarea caret measurement, keeping the existing card presentation while escaping clipped form and modal containers. Viewport collision handling keeps the menu usable in narrow and short layouts, and keyboard navigation keeps the selected option visible.
Field focus, pointer insertion, composition keys, blur dismissal, and Escape behavior are preserved across the shared writing controls. An open suggestion list handles Escape before its writing dialog closes. The superseded custom placement helper and its calculation-only tests are removed in favor of shared positioning and real-browser verification.
Validation:
Persistence and API contracts are unchanged.
Closes #215