Repository navigation
fix(http): exclude author-private entries from the shared timeline - #205
Merged
Merged
Conversation
Use public visibility for unscoped direct listings and preserve authorized private access for author-scoped reads. Extend transport parity and visitor coverage, and document the listing scopes in help and client guidance. Refs #202
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unscoped timeline reads now apply public visibility before pagination, excluding private originals and repost projections even when their author is signed in. Client-side post-change reconciliation follows the same boundary. Author-scoped feeds, personal archives and direct author access retain private visibility. Direct CLI listings use the same public default;
--author-idretains authorized access to the author's private publications.Validation:
mise exec -- node scripts/dev/test-go-group.mjs lifecyclepassed the complete lifecycle race group.mise exec -- go test ./internal/transport/http/gin -count=1,mise exec -- go vet ./internal/transport/cli ./internal/transport/http/gin, andmise exec -- golangci-lint run ./internal/transport/cli/...passed.mise exec -- pnpm --dir web test src/features/timeline/TimelinePage.test.tsx src/features/timeline/timelineItems.test.ts src/features/profile/profileTimeline.test.tspassed all 30 tests.mise exec -- pnpm --dir web build, focused ESLint, Prettier and diff checks passed.Visibility coverage compares direct and API data for public and author-scoped listings and verifies visitor filtering. The help snapshot is updated only for the revised listing description.
Full local CI and release checks were omitted because the lifecycle, transport and timeline suites cover this visibility boundary. There are no storage, schema or API query-shape changes.
Closes #202