Add scheduleEnd to dismiss a Live Activity at a future date#180
Open
jenow wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now
endActivityis the only way to stop an activity, and it dismisses itimmediately. I ran into a case where I wanted to end one but have the system keep
it on the lock screen until a set time and then drop it on its own, even if the
app gets killed in the meantime and no push ever shows up.
ActivityKit already handles this with
end(dismissalPolicy: .after(date)), itjust wasn't exposed anywhere, so this wires it up as
scheduleEnd:A couple of things about how
.afteractually behaves that tripped me up:Text(.timer)keeps counting down on thelock screen card by itself
One thing I had to work around: once you schedule the end, the activity is gone
from
Activity.activities, so a plainendActivitycan't find it to clear itearly. I keep a reference to the ended activity so
endActivitycan still killthe card immediately if you need it gone before the timer's up (cancelled
countdown, etc.).
iOS 16.1+. Also added a
scheduleEndstub to the test mock so the platforminterface test still compiles.