Repository navigation
fix(ws): percent-encode sign-server route params in the WebSocket URI - #377
Merged
Merged
Conversation
Euler Stream now routes connections through its fallback push server (wss://ws-fallback.eulerstream.com/) and echoes the raw user agent back as a route param. The URI builder joined route params verbatim, so the handshake request-target contained literal spaces and parentheses and the server answered 400 Bad Request with an empty body. Encode route param values only; base params keep their pre-encoded preset values (browser_version) and are not double-encoded. Adds a regression test for both. Also fold the 400 handshake case into WebcastBlockedError and keep WebcastBlocked200Error as a backwards-compatible alias. Claude-Session: https://claude.ai/code/session_01GZ9hdAnN45CPpd5jZBArcW
isaackogan
temporarily deployed
to
github-pages
September 10, 2026 03:32 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Euler Stream now routes connections through its fallback push server (
wss://ws-fallback.eulerstream.com/) and echoes the rawuser_agentback as a route param.build_webcast_urijoined route params verbatim, so the handshake request-target contained literal spaces and parentheses and the server answered400 Bad Requestwith an empty body.browser_version) and are not double-encoded.tests/test_ws_utils.py.WebcastBlockedError; keepWebcastBlocked200Erroras a backwards-compatible alias.Verification
pytest17 passed,mypyclean on the lint workflow's module list.https://claude.ai/code/session_01GZ9hdAnN45CPpd5jZBArcW