Skip to content

Wrap QuinticPathPlanner target yaw changes - #785

Open
sylvesterkaczmarek wants to merge 1 commit into
isaac-sim:developfrom
sylvesterkaczmarek:fix/quintic-target-prim-yaw
Open

Wrap QuinticPathPlanner target yaw changes#785
sylvesterkaczmarek wants to merge 1 commit into
isaac-sim:developfrom
sylvesterkaczmarek:fix/quintic-target-prim-yaw

Conversation

@sylvesterkaczmarek

@sylvesterkaczmarek sylvesterkaczmarek commented Aug 21, 2026

Copy link
Copy Markdown

Description

Fix the remaining yaw-change comparison issue in QuinticPathPlanner.

Isaac Sim 6.1 already contains the upstream fix for signed yaw extraction from targetPrim. The remaining comparison still subtracts yaw values directly, so physically close headings on opposite sides of +pi/-pi can look almost 2*pi apart and trigger an unnecessary replan.

This change compares the normalized angular delta instead, using the existing normalize_angle() helper.

Validation

  • regression added to the existing navigation quaternion test suite
  • verifies +179° -> -179° is treated as an approximately 2° change
  • source and test files pass py_compile
  • patch passes git diff --check
  • production change is one expression

Signed-off-by: Sylvester Kaczmarek <16242628+sylvesterkaczmarek@users.noreply.github.com>
@sylvesterkaczmarek
sylvesterkaczmarek force-pushed the fix/quintic-target-prim-yaw branch from f3709fc to 9b3c030 Compare September 12, 2026 15:59
@sylvesterkaczmarek sylvesterkaczmarek changed the title Preserve signed target yaw in QuinticPathPlanner Wrap QuinticPathPlanner target yaw changes Sep 12, 2026
@sylvesterkaczmarek

Copy link
Copy Markdown
Author

Rebased onto the 6.1 GA develop branch and narrowed to the remaining issue: target-yaw change detection now uses the shortest wrapped angular delta. The signed targetPrim yaw fix is already upstream. Added the regression to the existing navigation test suite; py_compile and git diff --check pass.

@copy-pr-bot

copy-pr-bot Bot commented Sep 12, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant