Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for unobfuscated Minecraft snapshots (starting with 26.1-snapshot-1) by introducing a comprehensive ClassTweaker system to replace the previous AccessWidener implementation. The key changes include:
- Renamed the legacy
loomplatform tofabric-loom-remapfor versions requiring remapping, and added a newfabric-loomplatform for unobfuscated versions - Rewrote AccessWidener parsing into a more flexible ClassTweaker format that supports multiple formats (AT, AW_V1, AW_V2, and the new CT format)
- Added version detection logic to identify unobfuscated Minecraft versions
Reviewed changes
Copilot reviewed 45 out of 47 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
src/main/kotlin/dev/isxander/modstitch/util/ClassTweaker.kt |
New comprehensive ClassTweaker implementation replacing AccessWidener with support for multiple formats |
src/main/kotlin/dev/isxander/modstitch/util/MinecraftVersion.kt |
Completely rewritten to support modern (year.drop) and legacy (1.minor.patch) version formats with proper comparison |
src/main/kotlin/dev/isxander/modstitch/base/loom/BaseLoomImpl.kt |
Updated to support both remapping and non-remapping Loom platforms |
src/main/kotlin/dev/isxander/modstitch/base/extensions/Modstitch.kt |
Renamed accessWidener properties to classTweaker, added isUnobfuscated detection |
src/main/kotlin/dev/isxander/modstitch/util/Platform.kt |
Added LoomRemap platform and updated platform enumeration |
src/test/kotlin/dev/isxander/modstitch/unit/ClassTweakerTest.kt |
New comprehensive test suite for ClassTweaker format parsing and conversion |
gradle.properties |
Updated Loom and ModDevGradle dependency versions |
build.gradle.kts |
Updated plugin-publish version |
Comments suppressed due to low confidence (1)
src/test/kotlin/dev/isxander/modstitch/integration/ClassTweakerIntegration.kt:53
- Debug println statement should be removed before merging to production.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/main/kotlin/dev/isxander/modstitch/base/loom/AppendFabricMetadataTask.kt
Show resolved
Hide resolved
src/test/kotlin/dev/isxander/modstitch/integration/AutoJavaVersionTests.kt
Show resolved
Hide resolved
src/test/kotlin/dev/isxander/modstitch/unit/ClassTweakerTest.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/dev/isxander/modstitch/base/moddevgradle/BaseModDevGradleImpl.kt
Show resolved
Hide resolved
src/main/kotlin/dev/isxander/modstitch/base/moddevgradle/BaseModDevGradleImpl.kt
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent Minecraft snapshots are no longer obfuscated. This PR aims to allow Modstitch to work with such versions.
loomplatform tofabric-loom-remapand added newfabric-loomplatform for no-remap versions