This repository was archived by the owner on May 1, 2026. It is now read-only.
fix: Read stdin directly for onboard Enter prompt#23
Merged
Conversation
bufio.NewReader can conflict with tap/bubbletea's raw-mode terminal handling, causing the Enter prompt to not register. Read one byte at a time from os.Stdin directly instead.
go-tty (used by tap) opens /dev/tty directly and disables echo/canonical mode on it. The previous stty sane targeted stdin which is a different fd. Now we open /dev/tty explicitly for stty sane, then syscall.Exec into SSH to kill tap's background readKeys goroutine that was stealing input bytes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bufio.NewReader(os.Stdin).ReadBytes('\n')with a direct byte-at-a-time read fromos.Stdinbufio.NewReadercan conflict with tap/bubbletea's raw-mode terminal handling, causing the "Press Enter to connect" prompt to not register keypresses