feat(oauth): fail open on token mint failure by default#194
Merged
Conversation
oauth_token previously rejected every matching request with a 502 when minting failed, so one broken credential took down all traffic the entry matched. Default to forwarding the request without the token instead, and add a per-entry "require: true" flag to opt back into failing closed, mirroring the secrets transform's require semantics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
oauth_token previously rejected every matching request with a 502 when a token mint failed, so one broken credential took down all traffic the entry matched. This changes the default to forward the request without the token instead, and adds a per-entry
require: trueflag to opt back into failing closed (502), mirroring the secrets transform'srequiresemantics.Note: this flips the default from fail-closed to fail-open. Existing configs that relied on the 502 rejection should add
require: true.