[#726,#774] Migrate to pyproject.toml and add GH action for ruff
#790
+532
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trel
reviewed
Jan 23, 2026
|
|
||
| jobs: | ||
| ruff-lint: | ||
| uses: SwooshyCueb/irods_reusable_github_workflows/.github/workflows/linter-irods-ruff.yml@main |
Member
There was a problem hiding this comment.
we'd update this to irods namespace once we're happy...
Member
Author
There was a problem hiding this comment.
Right. Also, this PR was supposed to be in my fork, not in the actual repo. But GitHub has a lot of dark patterns to try and prevent that I guess
SwooshyCueb
changed the title
pyproject.toml and add GH action for ruff
korydraughn
reviewed
Jan 23, 2026
Comment on lines
+85
to
+88
| indent-width = 4 | ||
|
|
||
|
|
||
| [tool.ruff.format] |
Contributor
There was a problem hiding this comment.
I think this is the only place I've seen two empty lines. Is that intentional?
alanking
reviewed
Jan 26, 2026
|
|
||
| [tool.ruff.format] | ||
| quote-style = "preserve" | ||
| indent-style = "space" |
Contributor
There was a problem hiding this comment.
I imagine we will want to flip this to tabs if/when we run the formatter on the codebase?
Member
Author
|
Converting to draft, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #726
Addresses #774