Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion guidebot_recorder/guide/capture.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
def scenario_resolve_url(scenario, url: str | None) -> str:
"""Resolve a possibly-relative navigate URL against the scenario base_url.

Mirrors ``render._resolve_url`` (render.py:1474-1478): relative URLs are
Mirrors ``_resolve_url`` in ``recorder/render/reuse.py``: relative URLs are
joined onto ``config.base_url`` with ``urljoin`` only when a base is
configured; an absolute URL, or the absence of a base, passes through
unchanged. ``url`` is defensively allowed to be ``None`` (navigate steps
Expand Down
2 changes: 1 addition & 1 deletion guidebot_recorder/guide/guide.py
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ async def run_guide(
scan_for_blockers(flat, compiled.actions)

cfg = scenario.config
# Same context recipe as run_render (render.py ~1705-1734), minus
# Same context recipe as run_render (recorder/render/_run.py), minus
# record_video_dir/record_video_size: PDF capture never records video.
context = await browser.new_context(
viewport={"width": cfg.viewport.width, "height": cfg.viewport.height},
Expand Down
3 changes: 2 additions & 1 deletion guidebot_recorder/models/scenario.py
Original file line number Diff line number Diff line change
Expand Up @@ -556,7 +556,8 @@ def select_mode(step: Step, cfg: Config) -> str:

Lives with the two models it reads rather than with either phase that
dispatches on it: it is a pure lookup over ``Step`` and ``Config``, and
homing it in ``compile.py`` made ``render.py`` import the compiler for it.
homing it in the compile package made the render package import the compiler
for it.
"""

if step.select is not None and step.select.mode is not None:
Expand Down
5 changes: 3 additions & 2 deletions guidebot_recorder/recorder/recorder.py
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,9 @@ class SelectDriveError(RuntimeError):
be rewritten.

The render layer catches this and re-raises it as a ``RenderError`` carrying
the index of the failing step. ``RenderError`` lives in ``render.py``, which
imports this module, so it cannot be raised from here without a cycle.
the index of the failing step. ``RenderError`` lives in
``recorder/render/errors.py``, whose package imports this module, so it cannot
be raised from here without a cycle.
"""

def __init__(self, message: str, *, reason: str = UNDRIVABLE) -> None:
Expand Down
Loading
Loading