Skip to content

fix: restore cryptography dependency to requirements.txt (#13055) - #13056

Closed
RsbhThakur wants to merge 1 commit into
internetarchive:masterfrom
RsbhThakur:13055/fix/restore-cryptography-dependency
Closed

fix: restore cryptography dependency to requirements.txt (#13055)#13056
RsbhThakur wants to merge 1 commit into
internetarchive:masterfrom
RsbhThakur:13055/fix/restore-cryptography-dependency

Conversation

@RsbhThakur

Copy link
Copy Markdown
Contributor

Restores cryptography==44.0.2 to requirements.txt (alphabetically under beautifulsoup4).

Closes #13055

fix

Technical

  • PR feat(security): store S3 keys as encrypted session cookie #12860 (merged 2026-06-25) introduced session cookie encryption for S3 keys, importing cryptography.fernet.Fernet and pinning cryptography==44.0.2 in requirements.txt.
  • PR feat(proxy): route outbound requests through single authenticated http_proxy #12724 (merged 2026-06-27) updated outbound request proxies, but its requirements.txt diff accidentally omitted/removed cryptography==44.0.2 during dependency updates.
  • The imports in openlibrary/accounts/model.py are still live, meaning fresh environments or clean builds that pull dependencies from requirements.txt crash with a ModuleNotFoundError on /account/login.
  • This PR restores the cryptography==44.0.2 requirement alphabetically.

Testing

  1. Rebuild the development containers to fetch and install the restored dependency:
    docker compose build --no-cache && docker compose up -d
  2. Navigate to http://localhost:8080/account/login and verify that the page loads and login succeeds smoothly.

Screenshot

N/A (Backend dependency fix. Traceback screenshot is available in #13055)

Stakeholders

@mekarpeles

…hive#13055)

Restores cryptography==44.0.2 to requirements.txt (alphabetically under beautifulsoup4).
@github-actions github-actions Bot added the Priority: 1 Do this week, receiving emails, time sensitive, . [managed] label Jun 29, 2026
@openlibrary-bot

Copy link
Copy Markdown
Collaborator

Thank you @RsbhThakur for this PR! Welcome to Open Library — great to have you contributing!

🤖 Copilot has been assigned for an initial review.

The linked issue (#13055) has been triaged (Priority: 1). A reviewer must first be assigned. There are currently 100+ open non-draft PRs ahead of yours in the queue, though the Priority: 1 label means this should be picked up promptly.

PR triage checklist (maintainers / Richy)

Note

This comment was automatically generated by PAM, Open Library's Project AI Manager. PAM provides status visibility, performs basic project management functions, and gives actionable feedback so contributors aren't left waiting.

@RsbhThakur

Copy link
Copy Markdown
Contributor Author

Hi @mekarpeles, I noticed the cryptography fix has just been merged as part of the rebase cleanup in #13063. Since the issue is resolved now, I'll close this PR. Glad to see it sorted out!

@RsbhThakur RsbhThakur closed this Jun 30, 2026
@RsbhThakur
RsbhThakur deleted the 13055/fix/restore-cryptography-dependency branch June 30, 2026 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs: Response Issues which require feedback from lead Priority: 1 Do this week, receiving emails, time sensitive, . [managed]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing cryptography dependency breaks /account/login (regression from #12724)

2 participants