fix(interledger-app): added pti_forms_url and pti_sdk_url to chart#409
Merged
fix(interledger-app): added pti_forms_url and pti_sdk_url to chart#409
Conversation
bosbaber
changed the title
github-actions bot
added a commit
that referenced
this pull request
Apr 1, 2026
Automated chart versioning after merge of PR #409. This PR updates Chart.yaml versions, packages updated charts into docs/interledger, and regenerates the Helm index. Co-authored-by: bosbaber <1615407+bosbaber@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds new PTI configuration values to the Interledger App backend Helm chart so PTI client-facing URLs can be provided via values and surfaced through the generated ConfigMap, with Helm validation updated accordingly.
Changes:
- Added
config.pti.sdk_urlandconfig.pti.forms_urlto the chart values and ConfigMap key mapping. - Updated Helm validation to require these fields when
config.pti.enabledis"true". - Extended helm-unittest coverage to assert the new fields appear in rendered output and validation success cases.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| charts/interledger-app/backend/values.yaml | Introduces PTI sdk_url / forms_url values and exposes them via ConfigMap key mapping. |
| charts/interledger-app/backend/templates/validate.yaml | Adds the new PTI fields to the “required when enabled” validation list. |
| charts/interledger-app/backend/tests/validate.gatehub_test.yaml | Updates validation success scenarios to include the new PTI required fields. |
| charts/interledger-app/backend/tests/deployment.server.configmaps_test.yaml | Adds assertions that the rendered ConfigMap contains PTI_SDK_URL and PTI_FORMS_URL. |
Comment on lines
219
to
+223
| base_url: "https://pti-base-url.com" | ||
| # Non-secret PTI SDK URL used by clients to load the PTI widget script. | ||
| sdk_url: "https://sdk.staging.fiant.io/latest/index.js" | ||
| # Non-secret PTI forms URL used by clients to host PTI widget forms. | ||
| forms_url: "https://forms.staging.fiant.io" |
There was a problem hiding this comment.
The new default PTI URLs point at FIANT staging endpoints. If a deploy enables PTI but forgets to override these values, clients could inadvertently load a staging widget script/forms in production. Consider using empty or clearly non-routable/example placeholders here (and rely on validate.yaml to enforce setting them when PTI is enabled).
Suggested change
| base_url: "https://pti-base-url.com" | |
| # Non-secret PTI SDK URL used by clients to load the PTI widget script. | |
| sdk_url: "https://sdk.staging.fiant.io/latest/index.js" | |
| # Non-secret PTI forms URL used by clients to host PTI widget forms. | |
| forms_url: "https://forms.staging.fiant.io" | |
| base_url: "https://pti-base-url.example.invalid" | |
| # Non-secret PTI SDK URL used by clients to load the PTI widget script. | |
| sdk_url: "https://pti-sdk.example.invalid/latest/index.js" | |
| # Non-secret PTI forms URL used by clients to host PTI widget forms. | |
| forms_url: "https://pti-forms.example.invalid" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.