Throw exception on plugin ep creation failure #894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR restores exception-throwing behavior when plugin execution provider initialization fails, aligning it with the behavior of bridge execution providers. Previously, a failed plugin EP would log an error and return nullptr; now it throws an exception during session creation.
Key Changes:
- Modified error handling in
PluginExecutionProviderFactory::CreateProviderto throw an exception instead of logging and returning nullptr when plugin EP creation fails
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
adrianlizarraga
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Keep behavior consistent between plugin eps and bridge eps: Throw an exception during session creation if an plugin ep fails to initialize.
Motivation and Context
Failure of negative test cases due to a behavior change in ORT commit