fix(agentic): redact report/CLI/timer statements - #307
Closed
innocarpe wants to merge 1 commit into
Closed
Conversation
Q1.5′ (QD7 / Q-S12): default operator JSON for flush/run/list-held/list-claims strips statements, quotes, and prepared pack views. --verbose opts in. Timer path stays non-verbose so agentic-timer.log does not log private prose.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agentic flush/run/list-held/list-claimsJSON redacts candidate statements, citation quotes, and prepared pack views ([redacted]).--verboseflag opts into full private text for interactive debug only.agentic-timer.logmust not carry statements).Why
Quality ultragoal dual review B-v2-1 blocked transcript recovery (Q3′) until report/timer surfaces stop leaking private statements and quotes. Flush/run currently nested full pipeline proposals (statement + quote + extract views) into operator JSON and timer stdout. That violates the privacy fence and makes dogfood receipts unsafe to share.
This is Q1.5′ (stacked on Q1′ prepared-pack views). Do not start Q3′ until this and Q2.5′ are green.
Scope and changes
packages/agentic/src/report.ts—redactAgenticRunnerReport/ pipeline / proposal helpers + leak probeapps/carpeos-cli— wire redaction into flush, run, list-held, list-claims;--verbosescripts/install-agentic-timer.sh— document no--verboseon timer--verboserestores full textLabels
fixArchitecture/data-contract impact
redacted/verbosefields on flush/run/list paths.AgenticRunnerReporttype is unchanged; redaction is a serialization boundary for operator output.feat/agentic-q1-prepared-pack-views) — merge after Q1′.Validation
pnpm --filter @carpeos/agentic testmake preflight-fixPublic-data/security boundary
Compatibility/migrations/deployment
--verbose.Risks and rollback
--verbose.Review guide
packages/agentic/src/report.tsand CLI flush/run writeJson sites--verbose; default redaction covers extract_view_textpnpm --filter @carpeos/agentic exec vitest run test/report.test.tsOut of scope/follow-ups
Checklist
.github/labels.jsononlyfeat/agentic-q1-prepared-pack-views(PR fix(agentic): prepared pack + effective Flash views #306)