Merged
Conversation
avazquezdev
previously approved these changes
Feb 10, 2026
JamVM needs a java compiler when building for GNU Classpath, in order to compile the VM support classes (classes.zip). The javac invocation uses -bootclasspath, but on JDK 9+ this needs explicit -source/-target. Fix by adding -source 1.6 -target 1.6 to javac options (same as used by GNU Classpath itself). Signed-off-by: Guillermo Rodríguez <grodriguez@ingelabs.com>
eeee073 to
a172c63
Compare
Contributor
Author
|
Reverted the GCJ/Jikes change. This PR was only about adding support for newer javac. |
avazquezdev
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JamVM needs a java compiler when building for GNU Classpath, in order to compile the VM support classes (classes.zip). Currently, this breaks on JDK 9 or later, since the javac invocation uses -bootclasspath, which (on JDK 9+) needs explicit -source/-target.
Fix by adding -source 1.6 -target 1.6 to javac options (same as used by GNU Classpath itself).
While we are at this, also drop support for GCJ and Jikes. GCJ was officially discontinued in 2016 (removed from GCC 7). Jikes support was also removed from GNU Classpath long ago.