Fix missing break in nativeExtraArg for linux/aarch64#3
Merged
guillerodriguez merged 1 commit intomasterfrom Jan 28, 2026
Merged
Fix missing break in nativeExtraArg for linux/aarch64#3guillerodriguez merged 1 commit intomasterfrom
guillerodriguez merged 1 commit intomasterfrom
Conversation
The switch statement for 'F'/'D' (float/double) cases was missing a break, causing fall-through to the default case. This incorrectly counted each float/double against both the FP and integer register budgets, potentially over-allocating stack space. Signed-off-by: Guillermo Rodríguez <grodriguez@ingelabs.com>
phvega
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The switch statement for 'F'/'D' (float/double) cases was missing a break, causing fall-through to the default case. This incorrectly counted each float/double against both the FP and integer register budgets, potentially over-allocating stack space.