Fix signature of scandir filter callback for Darwin#12
Merged
guillerodriguez merged 1 commit intomasterfrom Feb 11, 2026
Merged
Fix signature of scandir filter callback for Darwin#12guillerodriguez merged 1 commit intomasterfrom
guillerodriguez merged 1 commit intomasterfrom
Conversation
According to POSIX 2008, the scandir filter callback takes a
const dirent pointer. The existing code used the const-qualified
signature for Linux only, but Darwin requires it too. This caused
a warning (-Wincompatible-function-pointer-types) which recent
versions of clang treat as a hard error:
error: incompatible function pointer types passing
'int (*)(struct dirent *)' to parameter of type
'int (*)(const struct dirent *)'
Fix by using the correct POSIX signature on Darwin as well.
The non-const fallback is kept for older non-conforming systems.
Signed-off-by: Guillermo Rodríguez <grodriguez@ingelabs.com>
avazquezdev
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to POSIX 2008, the scandir filter callback takes a const dirent pointer. The existing code used the const-qualified signature for Linux only, but Darwin requires it too. This caused a warning (-Wincompatible-function-pointer-types) which recent versions of clang treat as a hard error:
error: incompatible function pointer types passing
'int (*)(struct dirent )' to parameter of type
'int ()(const struct dirent *)'
Fix by using the correct POSIX signature on Darwin as well. The non-const fallback is kept for older non-conforming systems.