Skip to content

fix: recursively copy entire skill directory during install - #31

Merged
Minitour merged 1 commit into
mainfrom
fix/install-copy-full-skill-directory
Mar 21, 2026
Merged

Minitour merged 1 commit into
mainfrom
fix/install-copy-full-skill-directory

Conversation

@Minitour

@Minitour Minitour commented Mar 21, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Bug: When installing a skill (local, GitHub, or GitLab), only \SKILL.md\ and top-level files were copied. Subdirectories and their contents were silently skipped.
  • Fix: Made
    eadSkillFromDirectory\ recursively traverse subdirectories, collecting all files with their relative paths. The existing write logic already supports nested paths via \mkdirSync({ recursive: true }), so no changes were needed on the install side.
  • Security checks (blocked phrases, character sanitization) continue to apply to all collected files.

Test plan

  • Install a skill that has files in subdirectories (e.g.
    eferences/\ folder) from a local path and verify the entire directory tree is copied
  • Install a skill from a GitHub repo with nested reference files and verify all files are present
  • Install a skill with only \SKILL.md\ (no subdirectories) and verify it still works as before
  • Verify security checks (blocked phrases) still apply to files in subdirectories

Made with Cursor

readSkillFromDirectory only iterated top-level files, silently
skipping subdirectories. Skills with reference files in nested
folders were installed with only SKILL.md, breaking any skill
that ships additional assets in subdirectories.
@Minitour
Minitour merged commit 309a18f into main Mar 21, 2026
4 checks passed
@Minitour
Minitour deleted the fix/install-copy-full-skill-directory branch March 21, 2026 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant