Skip to content

Fix null option values crashing TailwindTrait::getTwClasses() #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iruzevic merged 2 commits into from
Jun 11, 2026
Merged

Fix null option values crashing TailwindTrait::getTwClasses() #492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de23aa1
Fix null option values crashing TailwindTrait::getTwClasses()
iobrado Jun 11, 2026
de15240
Add missing diff
iobrado Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.

This projects adheres to [Semantic Versioning](https://semver.org/) and [Keep a CHANGELOG](https://keepachangelog.com/).

## [13.1.1]

### Fixed

- Fixed `TailwindTrait::getTwClasses()` to skip `null` option values returned by `Helpers::checkAttr()` instead of passing them to `processOption()`, preventing a type error when an attribute is absent from the block attributes.

## [13.1.0]

### Fixed
Expand Down Expand Up @@ -1192,6 +1198,7 @@ Init setup
- Gutenberg Blocks Registration.
- Assets Manifest data.

[13.1.1]: https://github.com/infinum/eightshift-libs/compare/13.1.0...13.1.1
[13.1.0]: https://github.com/infinum/eightshift-libs/compare/13.0.0...13.1.0
[13.0.0]: https://github.com/infinum/eightshift-libs/compare/12.3.4...13.0.0
[12.3.4]: https://github.com/infinum/eightshift-libs/compare/12.3.3...12.3.4
Expand Down
4 changes: 4 additions & 0 deletions src/Helpers/TailwindTrait.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,6 +472,10 @@ public static function tailwindClasses(string $part, array $attributes, array $m
foreach ($options as $attributeName => $defs) {
$optionValue = Helpers::checkAttr($attributeName, $attributes, $manifest, true);

if ($optionValue === null) {
continue;
}

if (\is_bool($optionValue)) {
$optionValue = $optionValue ? 'true' : 'false';
}
Expand Down