Conversation
inducer
reviewed
Nov 24, 2021
Owner
inducer
left a comment
inducer
left a comment
There was a problem hiding this comment.
Thanks! Mostly LGTM, only a few small wrinkles.
kaushikcfd
force-pushed
the
rename_inames
branch
from
ce579b9 to
f17b833
Compare
kaushikcfd
force-pushed
the
rename_inames
branch
from
f17b833 to
f00e72a
Compare
inducer
reviewed
Dec 28, 2021
Owner
inducer
left a comment
inducer
left a comment
There was a problem hiding this comment.
Thanks for working on this! I found a few superficial things. This is good to go once those are addressed.
kaushikcfd
force-pushed
the
rename_inames
branch
from
367b518 to
66b8f3c
Compare
Owner
|
Thanks! Looks great, in it goes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Q. Why not use
rename_inamerepeatedly?A. That would lead to multiple traversals of the IR and hence would bump up the operation complexity of certain transformations like Loop Fusion.