Outlook: Remove remaining check_existing usage #219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThiefMaster
force-pushed
the
outlook-fix-clone-delete
branch
2 times, most recently
from
ce363ea to
439a193
Compare
This resulted in incorrect calendar entries when creations were already queued and then those registrations were removed before the queue was processed. Since there was no existing entry, `check_existing` did not enqueue the deletions, so at the next task run all those deleted registrations had calendar entries anyway. An easy case where this can happen is someone cloning an event with registrations and then immediately deleting those registrations.
ThiefMaster
force-pushed
the
outlook-fix-clone-delete
branch
from
439a193 to
cf4ce2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resulted in incorrect calendar entries when creations were already queued and then those registrations were removed before the queue was processed. Since there was no existing entry,
check_existingdid not enqueue the deletions, so at the next task run all those deleted registrations had calendar entries anyway.An easy case where this can happen is someone cloning an event with registrations and then immediately deleting those registrations.