Skip to content

Allow to override the HttpClient #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ztec wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow to override the HttpClient #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion pinboard.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,8 @@ var (
}

pinboardToken = ""

httpClient = &http.Client{}
)

// get checks if endpoint is a valid Pinboard API endpoint and then
Expand Down Expand Up @@ -103,7 +105,7 @@ func get(endpoint string, options interface{}) (body []byte, err error) {
u.RawQuery = q.Encode()

// Call APImethod with fully constructed URL.
res, err := http.Get(u.String())
res, err := httpClient.Get(u.String())
if err != nil {
return nil, err
}
Expand Down Expand Up @@ -209,3 +211,9 @@ func values(i interface{}) (url.Values, error) {
func SetToken(token string) {
pinboardToken = token
}

// SetHttpClient sets teh actual http client instance to use to make calls.
// This can be overridden for caching purposes for example
func SetHttpClient(client *http.Client) {
httpClient = client
}