-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
feat: Shared Links: Slug Support, UI Refactor, and Simplified Actions #24856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Lauritz-Tieste
wants to merge
16
commits into
immich-app:main
Choose a base branch
from
Lauritz-Tieste:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+420
−400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rity and usability
Member
|
@Lauritz-Tieste Can you split this PR into multiple independent PRs so it'll be easier to get the simpler ones in? For instance, the slug support can go on it's own without the UI refactor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces support for a new
slugfield in theSharedLinkmodel and refactors the shared link UI for improved usability and maintainability. The changes ensure that slugs are handled throughout the model, service, and UI layers, and update the shared link list and item presentation for a more modern and user-friendly experience.Model and Service Enhancements:
slugfield to theSharedLinkmodel, updated constructors,copyWith, equality, and hashcode methods to includeslug.UI/UX Improvements:
SharedLinkItemwidget:slugif available and changed the URL path from/share/{key}to/s/{slug or key}.Dismissiblefor swipe-to-delete with confirmation, made the whole item tappable for editing, and enabled long-press to copy the link.How Has This Been Tested?
Screenshots (if appropriate)
Screen_Recording_20251226_185149.mp4
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)Please describe to which degree, if any, an LLM was used in creating this pull request.
GPT-5-Codex for time selection mechanism and GitHub Copilot for PR Summary