fix: Show correct photo name in buttom sheet and backup details page #22978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Label error. Requires exactly 1 of: changelog:.*. Found: 📱mobile. A maintainer will add the required label. |
FawenYo
force-pushed
the
fix/fetch-origin-name-more-fixes
branch
from
837a0f7 to
a20275a
Compare
FawenYo
force-pushed
the
fix/fetch-origin-name-more-fixes
branch
from
a20275a to
51836ba
Compare
Member
|
Are these photos from Shared Albums that are shared with you? |
Contributor
Author
|
Hi @alextran1502 , yes! |
alextran1502
merged commit d626f86
into
immich-app:fix/fetch-origin-name
1 of 2 checks passed
shenlong-tanwen
pushed a commit
that referenced
this pull request
Oct 27, 2025
alextran1502
pushed a commit
that referenced
this pull request
Oct 27, 2025
* fix: fetch origin name before upload * fix: Show correct photo name in buttom sheet and backup details page (#22978) * add tests --------- Co-authored-by: shenlong-tanwen <[email protected]> Co-authored-by: FawenYo <[email protected]>
bwees
pushed a commit
to exelix11/immich
that referenced
this pull request
Nov 7, 2025
* fix: fetch origin name before upload * fix: Show correct photo name in buttom sheet and backup details page (immich-app#22978) * add tests --------- Co-authored-by: shenlong-tanwen <[email protected]> Co-authored-by: FawenYo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a follow-up PR to #21877. The goal is to use the same approach to fix an issue where the file names of some assets in the photo bottom sheet and backup details pages are displayed in UUID format instead of the correct file name.
Fixes #20630
How Has This Been Tested?
I've tried to compile the app and installed it on my iPhone, and all photos display the correct name now
Screenshots (if appropriate)
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)Please describe to which degree, if any, an LLM was used in creating this pull request.
mobile/lib/pages/backup/drift_backup_asset_detail.page.dartwas manually written, andmobile/lib/presentation/widgets/asset_viewer/bottom_sheet.widget.dartwas processed by an LLM following the same modification approach. I believe the changes made are reasonable.