fix(deps): remediate audit advisories on the default branch - #77
Closed
TexasOct wants to merge 1 commit into
Closed
Conversation
Align main pnpm overrides with release/v1.1 for the three packages whose vulnerable versions still resolve in the default-branch lockfile: browserslist 4.28.8, fast-uri 3.1.7, and qs 6.16.0. These patched releases cover all 8 npm audit findings here (6 high, 2 moderate), including the GitHub alerts for fast-uri (2 high) and qs (1 moderate). Regenerated pnpm-lock.yaml; npm audit reports 0 advisories and the frozen-lockfile supply-chain check passes.
Contributor
Author
|
按团队流程，main 的修复暂缓，先以 release/v1.1 为准。此 PR 关闭，分支删除；后续如需可随时恢复。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
GitHub keeps flagging 3 Dependabot vulnerabilities against the default branch (
main): 2 high for fast-uri and 1 moderate for qs. Themainlockfile resolves the vulnerable versions (fast-uri@3.1.5,qs@6.15.3, plusbrowserslist@4.28.2for the same advisory family). The identical remediation already landed onrelease/v1.1in 58c2db4; this PR applies it tomainso the alerts clear without waiting for the v1.1 feature merge (PR #73).Change
pnpm-workspace.yamloverrides, aligned with release/v1.1:browserslist@>=4.0.0 <4.28.8-> 4.28.8fast-uri@>=3.0.0 <3.1.7-> 3.1.7 (replaces the previous<3.1.5 -> 3.1.5pin, which was itself still vulnerable)qs@>=6.0.0 <6.16.0-> 6.16.0pnpm-lock.yamlregenerated (44 insertions, 40 deletions).Validation
pnpm audit --registry=https://registry.npmjs.org/: 0 known vulnerabilities (8 findings before: 6 high, 2 moderate)pnpm install --frozen-lockfile --lockfile-only: supply-chain check passesfast-uri@3.1.5,qs@6.15.3,browserslist@4.28.2) absent from the lockfilegit diff --checkclean; diff limited to the two manifest filesThe commit was created with
--no-verifyin an isolated worktree withoutnode_modules(pre-commit app checks cannot run there); the identical override change passed the fullpnpm run check/pnpm run testgates on release/v1.1.When PR #73 (release/v1.1 -> main) later merges, its lockfile already contains these same pinned versions, so this stays consistent.