Conversation
mochaaP
commented
Sep 10, 2025
mochaaP
commented
- Add meson build system
- Sync cmake's installation layout to Makefile and Meson builds
CMakeLists.txt
Outdated
| ) | ||
| install (FILES pystring.h | ||
| DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}/${PROJECT_NAME} | ||
| DESTINATION ${CMAKE_INSTALL_INCLUDEDIR} |
There was a problem hiding this comment.
Does this mean it will no longer install in a pystring subdirectory? So software that had been doing
#include <pystring/pystring.h>
will stop working?
There was a problem hiding this comment.
Should we do this the other way around? Since we don't export a config file (.cmake/.pc) people either vendor it or do find_path(PYSTRING_INCLUDE_DIR pystring.h)
pystring.h: 25 repos
pystring/pystring.h: 7 repos
vcpkg and conan.io actively patch out all <pystring/pystring.h> to <pystring.h> or in reverse:
There was a problem hiding this comment.
See the conversions in:
#49
I think we do want to keep installing the header file to the /${PROJECT_NAME} sub directory.
That is the practice in different open source projects that we maintain, so wanting to keep it consistent.
Is there something stopping meson from doing that so that meson and cmake match?
There was a problem hiding this comment.
ack. will adjust meson & makefile to that convention.
There was a problem hiding this comment.
also should we keep -I<prefix>/include/pystring in pkg-config so #include <pystring.h> still works if one uses pkg-config?
There was a problem hiding this comment.
I am not sure about pkg-config. Are we supposed to provide a .pc file for that?
But with the adjustment to the /${PROJECT_NAME} sub directory this looks good to me.
There was a problem hiding this comment.
Done making it use the <pystring/pystring.h> form.
|
I would strongly recommend that this only be accepted if it also contains modifications that add cases to the CI test matrix that build pystring with meson and also run the tests. Without an automated test to ensure that the meson build always works, I think it's a pile of divergence-caused build bugs just waiting to happen. |
|
(If I'm being honest, I would also recommend that the .cpp be eliminated and make the entire pystring be a single file header-only library, and then you don't really need much of a "build system" at all.) |
sure, working on ci. |
mochaaP
force-pushed
the
master
branch
5 times, most recently
from
9828288 to
ede9e51
Compare
this pulls in an extra dependency on the cmake binary, CMake users can use the PkgConfig module instead.
grdanny
left a comment
grdanny
left a comment
There was a problem hiding this comment.
looks good. let's run with this and see how it goes.
3 participants
