Merged
Conversation
197g
approved these changes
Mar 16, 2026
Member
197g
left a comment
197g
left a comment
There was a problem hiding this comment.
They were at some point necessary. I don't fully recall all the details, but removed some others a while back. In any case it would be necessary if Any was involved for downcasting anywhere but sealing of the trait should have made any that direction redundant; no longer something to consider as a future possibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A lot of functions generic over pixels had
'staticbounds for pixels and subpixels. Frankly, I have no idea why they had these bounds. Everything compiles without them. I also checked whether there was someunsafecode relying on static lifetimes, but there wasn't. The bounds seem completely unnecessary.So I removed them all. I checked every
'staticbounds and removed the unnecessary ones.If there is a reason why these bounds exist and should be kept, please tell me.