Remove deprecated constructor for HdrDecoder#2865
Open
RunDevelopment wants to merge 2 commits intoimage-rs:mainfrom
Open
Remove deprecated constructor for HdrDecoder#2865RunDevelopment wants to merge 2 commits intoimage-rs:mainfrom
HdrDecoder#2865RunDevelopment wants to merge 2 commits intoimage-rs:mainfrom
Conversation
Contributor
|
This method was only deprecated 3 weeks ago, and the deprecation note points at a method that isn't public. I think this might need a bit more attention first... |
Member
Author
|
Good catch! I didn't check when it was deprecated. I think just explaining things a bit more in the docs of Also, should |
Member
Member
Author
|
Special or not, what's a constructor if not a static factory method? I just like to call them that here, since that's what their role is. But after looking at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I removed the deprecated and internally unused
new_nonstrictconstructor forHdrDecoder.This is the last deprecated item in
image.