Skip to content

Update EEG Utils & NBS_BCT Utils#2

Open
maddoxx02 wants to merge 16 commits into
iknyazeva:Trialsfrom
maddoxx02:master
Open

Update EEG Utils & NBS_BCT Utils#2
maddoxx02 wants to merge 16 commits into
iknyazeva:Trialsfrom
maddoxx02:master

Conversation

@maddoxx02

@maddoxx02 maddoxx02 commented Jun 5, 2025

Copy link
Copy Markdown
Collaborator
  • Added EEG Files (test_eeg_utils, eeg_utils, & eeg data .csv)
  • Updated nbs_utils.py (performs explicit thresholding for comparision with TFNOS)
  • Updated example notebook with minor figure changes.

Pending:

  • Add comments
  • Build ReadMe + graphical abstract
  • Add link to Datasets
  • Revision of all docStrings
  • Improve example.notebook + add markdowns with comments
  • Custom Build Docs
  • Pip package
  • Push Final

maddoxx02 and others added 9 commits April 10, 2025 13:28
@maddoxx02
update
7b9135e
@maddoxx02
Updates
be188c8 
- Doc_strings
- Initial Readme
@maddoxx02
Update README.md
1b2f50a
@maddoxx02
Updated Doctest
c69dfe1
@maddoxx02
Merge pull request #1 from maddoxx02/test
537a71e 
Doctest + DocStrings
@maddoxx02
Updated docs
56dce42 
Missing index
@maddoxx02
Added EEG Modules
97c7673
@maddoxx02
Updated nbs_utils.py
3e7a73a 
- Updated nbs_utils.py to include BCT_PY version of NBS - explicit threshold
- Updated example notebook
@maddoxx02
Removed Pre-built docs
1e62503
@maddoxx02 maddoxx02 requested review from Mezhbert and myxa June 5, 2025 22:17
myxa
myxa requested changes Jun 9, 2025
View reviewed changes

@myxa myxa left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!
Everything is cool a little bit and we are there

keep in mind closest goals:
deploying a pip package
prereqs for that

  • sphinx automated documentation -> doctests for all users functions
  • availability to apply tfnos to eeg data (check this part with Irina Sergeevna)

Comment thread README.md
Comment thread tests/test_eeg_utils.py
Comment thread tfnbs/eeg_utils.py
Comment thread tfnbs/eeg_utils.py
Comment thread tfnbs/nbs_utils.py Outdated
Comment thread tfnbs/utils.py Outdated
Comment thread tfnbs/pairwise_tfns.py
Comment thread tfnbs/tfnos.py
Comment thread tfnbs/utils.py
@maddoxx02
Update
bebd621 
- Revised DocStrings
- Added comments & descriptions where neccessary
- Improved readability

Pending:
- Add comments to TFNOS Notebook
- Add content to EEG Notebook
- Build Docs
- Send for review
@maddoxx02 maddoxx02 removed the request for review from Mezhbert June 24, 2025 14:42
@maddoxx02 maddoxx02 closed this Jun 24, 2025
@maddoxx02 maddoxx02 reopened this Jun 24, 2025
@maddoxx02 maddoxx02 requested a review from myxa July 3, 2025 13:54
@maddoxx02

maddoxx02 commented Jul 3, 2025

Copy link
Copy Markdown
Collaborator Author

Pending:

  • add actions
  • update readme with live details (i.e. email, doi etc)
  • readme image
  • usage section in documentation

maddoxx02 and others added 5 commits July 3, 2025 16:57
@maddoxx02
Update README.md
1378e9f
@maddoxx02
Update README.md
45e9545
@maddoxx02
Update README.md
b85374c
@maddoxx02
Update Contents
81f61cc 
- Pending Pre-defined clusters
- Test condition for NBS_Utils for Non-matching shapes of G1 & G2
@maddoxx02
Update README.md
b5c3bef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@myxa myxa Awaiting requested review from myxa

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maddoxx02 @myxa