Adapt to upstream gpf-schema-store v0.2.2 - #179
Conversation
52ee613 to
12ab11b
Compare
mborne
left a comment
There was a problem hiding this comment.
Mainly 2 points :
- Handle
dateanddate-timeby checking the format instead of inspecting the name of the property - Use the following fixture for geometry properties in tests :
"properties":{
"geometrie" : {
"x-ogc-role" : "primary-geometry",
"format" : "geometry-multipolygon"
}
}ac71468 to
197080b
Compare
afbd2c7 to
83c52f3
Compare
09e73cf to
b7d19b1
Compare
|
Uh ... code was peer reviewed but was it actually tested ? 🤔
"properties": {
"type": "string"
},
|
|
Now we have a difficulty: the goal of the main change of gpf-schema-store was to use OGC API Features output schemas. Those inherently have a
Barring objections I'll start by implementing 1 because it is by far the simplest option. We can revisit this problem as a separate issue later. |
91d9c2f to
a6102b0
Compare
Co-authored-by: mborne <mborne@users.noreply.github.com>
…tSchema for all tools Co-authored-by: Emmanuel S. <5435148+esgn@users.noreply.github.com>
Co-authored-by: Emmanuel S. <5435148+esgn@users.noreply.github.com>
Co-authored-by: Emmanuel S. <5435148+esgn@users.noreply.github.com>
… DetailedCollectionSearchMatch Co-authored-by: Emmanuel S. <5435148+esgn@users.noreply.github.com>
…t in a collection
…atureType object type
e1f709c to
f791f43
Compare
|
@esgn tested locally // FIXME: when mcp-framework is removed, remove this patch which is only here
// because mcp-framework does not accept z.record field types.
const gpfDescribeTypeOutput = zOgcCollectionSchema
.omit({ properties: true })
.catchall(z.unknown());The lack of schema about properties doesn't seem the interpretation of the values ("Décrit moi la modélisation des bâtiments BDTOPO" use the available informations) No problem found with geocontext-test ( except known issues ) : -> I think we can reference the FIXME in #112 and merge |

Main changes:
getCollectionSchema,search,CollectionSearchMatch).OgcCollectionSchema,OgcCollectionProperty) and adaptedproperty/enumhandling tooneOf.gpf_describe_typeandgpf_search_typesto reflect the new schema model.Close #142