Release 5.0.5 #3012
Open
Release 5.0.5 #3012
+11,966
−6,516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added Redis 8+, 9+ and Valkey 9+ support * Removed Redis 9 * Update docs/getting_started/requirements.md * Apply suggestions from code review
* Adjusted the doc * Selfreview * Apply suggestion from @mnocon * Reworked the doc: api_key examples and ES7 is still supported * Apply suggestions from Doc review Co-authored-by: julitafalcondusza <[email protected]> * Added suggestion that updating is recommended - and removed explicit version * Update docs/search/search_engines/elasticsearch/configure_elasticsearch.md Co-authored-by: Tomasz Dąbrowski <[email protected]> * Improved wording --------- Co-authored-by: julitafalcondusza <[email protected]> Co-authored-by: Tomasz Dąbrowski <[email protected]>
Contributor
adriendupuis
left a comment
adriendupuis
left a comment
There was a problem hiding this comment.
I would add a note into configure_elasticsearch.md about "this is for ES8, for ES7 look at" with a link to update_from_5.0.md#update-configuration
|
|
||
| - Linux NFS or S3/EFS (for IO, aka binary files stored in content repository, not supported with legacy) | ||
| - Redis 7.2+ (separate instances for session and cache, both using a `volatile-*` [eviction policy](https://redis.io/docs/latest/develop/reference/eviction/), session instance configured for persistence) | ||
| - Redis 7.2+, 8.4+, or Valkey 9.0+ (separate instances for session and cache, both using a `volatile-*` [eviction policy](https://redis.io/docs/latest/develop/reference/eviction/), session instance configured for persistence) |
Contributor
There was a problem hiding this comment.
It looks unfair to me to have links on Varnish and even Memcached on 4.6- tabs, and not for other elements.
Suggested change
| - Redis 7.2+, 8.4+, or Valkey 9.0+ (separate instances for session and cache, both using a `volatile-*` [eviction policy](https://redis.io/docs/latest/develop/reference/eviction/), session instance configured for persistence) | |
| - [Redis](https://redis.io/) 7.2+, 8.4+, or [Valkey](https://valkey.io/) 9.0+ (separate instances for session and cache, both using a `volatile-*` [eviction policy](https://redis.io/docs/latest/develop/reference/eviction/), session instance configured for persistence) |
Not sure it worths it. The Redis homepage is not very welcoming.
And the side quest would be to add more links for MySQL, MariaDB, Elasticsearch, and so on…
Contributor
Author
There was a problem hiding this comment.
I'd keep it "as is" for now, the technologies are well known - and it seems not worth the effort to make it unified for all memtions
* Adjusted the doc * Selfreview * Apply suggestion from @mnocon * Reworked the doc: api_key examples and ES7 is still supported * Apply suggestions from Doc review Co-authored-by: julitafalcondusza <[email protected]> * Release notes for 5.0.5 * Added suggestion that updating is recommended - and removed explicit version * Update docs/search/search_engines/elasticsearch/configure_elasticsearch.md Co-authored-by: Tomasz Dąbrowski <[email protected]> * Removed broken links * Removed broken fragment * Bumped mkdocs variable * Fixed image * Removed big TODO headers * Fixes * Adjusted headers * Apply suggestions from code review Co-authored-by: julitafalcondusza <[email protected]> --------- Co-authored-by: julitafalcondusza <[email protected]> Co-authored-by: Tomasz Dąbrowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes:
Waiting for: