Replace linear nonce replay scan with normalized hash set - #9
Open
notforhumansfun-rgb wants to merge 1 commit into
Open
notforhumansfun-rgb wants to merge 1 commit into
notforhumansfun-rgb wants to merge 1 commit into
Conversation
notforhumansfun-rgb
force-pushed
the
fix/hashed-nonce-replay
branch
from
August 26, 2026 07:09
b5060c1 to
6265d6b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7.
What changed
Context.seen_noncesinto a deduplicatedHashSet<[u8; 32]>0x-prefixed or non-32-byte nonce inputs before verificationNONCE_REPLAYwith a 100,001-entry set, plus malformed-input and normalization regressionsThe JSON wire shape remains
string[]; reason codes and normative check order do not change. The public Rust field type changes fromVec<String>toHashSet<[u8; 32]>, matching the issue proposal.Verification
cargo build --workspacecargo fmt --all -- --checkcargo clippy --workspace --all-targets -- -D warningscargo test --workspacepython crosscheck/verify.py vectors— 9/9python -m pytest crosscheck/test_crosscheck.py— 2/2