Skip to content

fix(assistant): canonicalize rule file storage#625

Merged
kaizhou-lab merged 5 commits into
mainfrom
fix/windows-assistant-rule-files
Jul 16, 2026
Merged

fix(assistant): canonicalize rule file storage#625
kaizhou-lab merged 5 commits into
mainfrom
fix/windows-assistant-rule-files

Conversation

@kaizhou-lab

Copy link
Copy Markdown
Contributor

Summary

  • percent-encode assistant IDs and locales used in rule/skill filenames so generated IDs such as bare:... do not create Windows alternate data streams
  • read and migrate exact legacy rule paths while preserving deterministic non-empty locale fallback for assistant details and conversation snapshots
  • remove unused assistant_definitions.rule_inline_content, source_version, and source_hash columns with migration 024

This addresses an independently verified Windows filename defect. Existing evidence does not prove that it caused Sentry ELECTRON-3EG, so this PR does not close that issue.

Verification

  • cargo test -p aionui-assistant read_rule_user_
  • cargo test -p aionui-app t1_3b_create_persists_available_locale_fallback_rule_in_assistant_snapshot
  • cargo test -p aionui-db migration_024_removes_unused_fields_and_preserves_definition
  • affected-crate clippy with -D warnings
  • migration immutability check, workspace fmt, and workspace clippy passed through just push

Full workspace nextest was stopped before completion per request and is not reported as passing.

@kaizhou-lab kaizhou-lab enabled auto-merge (squash) July 15, 2026 12:52
@kaizhou-lab kaizhou-lab merged commit 020a27a into main Jul 16, 2026
6 checks passed
@kaizhou-lab kaizhou-lab deleted the fix/windows-assistant-rule-files branch July 16, 2026 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant