Fix console errors when running from source in development#2640
Merged
sensei-hacker merged 1 commit intoMay 27, 2026
Merged
Conversation
Two spurious errors appeared every time the configurator ran from an untagged source checkout: - search.js logged "Failed to index JS for tab debug_trace/options" because those tabs have no .js file. Add a jslessTab exclusion set so their JS import is skipped; HTML indexing still runs normally. - appUpdater.js threw an uncaught TypeError from semver.gt() when the running version was an untagged git-describe string rather than a valid semver. Wrap the comparison in try/catch so non-release builds silently skip the update check.
Contributor
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
|
sensei-hacker
merged commit 0d69a45
into
iNavFlight:maintenance-9.x
7 of 8 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Eliminates two spurious console errors that appear every time the configurator is run from an untagged source checkout.
Changes
tabs/search.js— AddjslessTabexclusion set for tabs that have no.jsfile (debug_trace,options). Their JS import is now skipped; HTML indexing still runs normally, so search results for those tabs are unaffected.js/appUpdater.js— Wrap thesemver.gt()comparison in a try/catch so builds with non-semver version strings (e.g.untagged-<hash>from git-describe) silently skip the update check instead of throwing an uncaught TypeError.Errors eliminated
Testing
Verified in development mode (
yarn start) — both errors no longer appear in DevTools console. Update check still works correctly for release builds with valid semver versions.