Fix OSM 403: inject Referer and User-Agent for tile requests#2630
Open
sensei-hacker wants to merge 1 commit into
Open
Fix OSM 403: inject Referer and User-Agent for tile requests#2630sensei-hacker wants to merge 1 commit into
sensei-hacker wants to merge 1 commit into
Conversation
Contributor
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Fixes 403 errors from the OSM tile CDN when loading the map tab.
Electron provides no valid
Refererfor outgoing tile requests — packaged builds load pages fromfile://, and dev builds load fromhttp://localhost. OSM's CDN rejects both with 403. The fix registers awebRequest.onBeforeSendHeadershook on the default session at app startup that injects the requiredRefererandUser-Agentheaders on all requests totile.openstreetmap.org.Changes
js/main/main.js: importsessionfrom electron; registeronBeforeSendHeadershook inapp.on('ready', ...)(not insidecreateWindow(), to prevent double-registration) that injectsRefererand a policy-compliantUser-Agentfor OSM tile requestshttps://tile.openstreetmap.org/*(the URL OpenLayers actually uses) andhttps://*.tile.openstreetmap.org/*(CDN subdomain form)User-Agentusesapp.getVersion()so it tracks the package version dynamically rather than a hardcoded stringTesting
Notes
Cherry-picked and amended from MartinovEm's PR #2599 (
dff32ce). The original commit hardcoded the version string and used only the subdomain wildcard pattern; both issues are fixed here.