OSD elements i18n#2524
Conversation
PR Compliance Guide 🔍All compliance sections have been disabled in the configurations. |
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
| "osdElement_MISSION INFO": { | ||
| "message": "Mission Info" | ||
| }, |
There was a problem hiding this comment.
Suggestion: Replace the space with an underscore in the osdElement_MISSION INFO key to follow naming conventions and prevent potential lookup errors. [general, importance: 7]
| "osdElement_MISSION INFO": { | |
| "message": "Mission Info" | |
| }, | |
| "osdElement_MISSION_INFO": { | |
| "message": "Mission Info" | |
| } |
| "osdElement_DISTANCE_TO_HOME": { | ||
| "message": "Направление домой" | ||
| }, |
There was a problem hiding this comment.
Suggestion: Correct the Russian translation for osdElement_DISTANCE_TO_HOME to "Расстояние до дома" to accurately mean "Distance to Home". [possible issue, importance: 8]
| "osdElement_DISTANCE_TO_HOME": { | |
| "message": "Направление домой" | |
| }, | |
| "osdElement_DISTANCE_TO_HOME": { | |
| "message": "Расстояние до дома" | |
| } |
| "osd_pilot_name": { | ||
| "message": "Pilot's Name" | ||
| }, | ||
| "osdElement_POWER_SUPPLY_IMPEDANCE": { | ||
| "message": "Power Supply Impedance" | ||
| }, | ||
| "osdElement_REMAINING_FLIGHT_TIME": { | ||
| "message": "Remaining Flight Time" | ||
| }, | ||
| "osdElement_REMAINING_FLIGHT_DISTANCE": { | ||
| "message": "Remaining Flight Distance" | ||
| }, | ||
| "osdElement_THROTTLE_GAUGE": { | ||
| "message": "Throttle Gauge" | ||
| }, | ||
| "osdElement_THROTTLE_POSITION": { | ||
| "message": "Throttle Position" | ||
| }, | ||
| "osdElement_SCALED_THROTTLE_POSITION": { | ||
| "message": "Scaled Throttle Position" | ||
| }, | ||
| "osdElement_CRAFT_NAME": { | ||
| "message": "Craft Name" | ||
| }, |
There was a problem hiding this comment.
Suggestion: Remove the duplicate osd_craft_name translation entry and standardize on using osdElement_CRAFT_NAME to avoid inconsistency. [general, importance: 6]
New proposed code:
-"osd_craft_name": {
- "message": "Craft Name"
-},
"osdElement_CRAFT_NAME": {
"message": "Craft Name"
}
funkill
force-pushed
the
osd-elements-translation
branch
from
11224d5 to
3a97f1c
Compare
|
Do the Qodo bot comments make sense, or is it being goofy? |
|
|
The first comment was about organizing work with localization keys; this needs to be addressed at the project level. The second comment was helpful: I didn't notice a translation error and corrected it. The last comment was about the duplicate; I think it's best to leave it as is (so that changing the text in one place doesn't accidentally change it in another). |
|
2 participants
User description
Added en osd elements string (for simplify track in tools like weblate, pontoon, poeditor and other), extracted from osd.js, i18n keys creates here.
Added ru translations of new elements.
PR Type
Enhancement
Description
Added 47 English OSD element translations for internationalization
Added 47 Russian OSD element translations with localized descriptions
Fixed HTML tag syntax error in Russian FrSky fuel unit help text
Diagram Walkthrough
File Walkthrough
messages.json
Added 47 English OSD element translationslocale/en/messages.json
elements
throttle, heading, altitude, and various configuration parameters
messages.json
Added 47 Russian OSD translations and fixed HTML taglocale/ru/messages.json
settings
serialrx_frSkyFuelUnitHelp(changed«топливо»to«топливо»)