Fixes a bug in LocaleMatcher where locale parsing information is passed incorrectly#492
Merged
gouniLee merged 6 commits intodevelopmentfrom Apr 15, 2026
Merged
Fixes a bug in LocaleMatcher where locale parsing information is passed incorrectly#492gouniLee merged 6 commits intodevelopmentfrom
LocaleMatcher where locale parsing information is passed incorrectly#492gouniLee merged 6 commits intodevelopmentfrom
Conversation
…ted by the actual Locale object to reduce confusion
ehoogerbeets
reviewed
Apr 9, 2026
gouniLee
changed the title
LocaleMatcher where locale parsing information is passed incorrectly
ehoogerbeets
reviewed
Apr 9, 2026
ehoogerbeets
approved these changes
Apr 15, 2026
Co-authored-by: Edwin Hoogerbeets <ehoogerbeets@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
ReleaseNoteshas added or is not needed.NodejsandChrome Browser.QT/QML.Issue Resolved / Feature Added
Align the variable names passed by Localematcher with the order expected by the actual Locale object to reduce confusion.
This change is not a bug and does not affect existing behavior.
Resolution
Links