Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds comprehensive test coverage for special characters in folder names, addressing issue #30. The changes introduce proper URL encoding handling for test fixtures containing special characters like #, %, &, ?, and :.
Changes:
- Added new test cases for listing folders with special characters (whitespace, percent-encoded paths, and individual special characters)
- Refactored test infrastructure to use custom percent encoding for fixture file paths to avoid double-encoding issues
- Added convenience method to
Servingprotocol that returns an array of items instead of an AsyncThrowingStream
Reviewed changes
Copilot reviewed 36 out of 36 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Tests/RainmakerTests/URLTestSessionError.swift | Changed error case to use String path instead of URL for better error messages |
| Tests/RainmakerTests/URLTestSession.swift | Refactored fixture loading to use custom percent encoding via FileHandle to prevent double-encoding |
| Tests/RainmakerTests/ListingTests.swift | Added 7 new test cases for special character handling in folder names |
| Tests/RainmakerTests/Extensions/URL+percentEncodedPath.swift | New extension providing custom percent encoding for file system paths |
| Tests/RainmakerTests/Extensions/HTTPURLResponse+init.swift | Updated to accept Data instead of URL for fixture parsing |
| Sources/Rainmaker/Serving.swift | Added convenience method returning array of Items |
| Sources/Rainmaker/Server.swift | Implemented the new array-returning enumerate method |
| Sources/RainmakerCLI/Commands/List.swift | Simplified to use new array-returning enumerate method |
| Multiple fixture files | Added test response fixtures for special character test cases (31.0.12 and 32.0.3) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
i2h3
force-pushed
the
30-special-characters
branch
from
6d80f03 to
98f3d3b
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 36 out of 36 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
i2h3
force-pushed
the
30-special-characters
branch
from
98f3d3b to
7ab9b84
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.