Full Implementation of MistakeWidget and Overrides#4
Open
Gbeckler8 wants to merge 3 commits into
Open
Conversation
Implements the backend logic needed for Duolingo-style: "Override - I was correct". Have not done frontend work yet.
Improved logic to have better data storage/more utility for the backend of user-overrided mistakes
Finishes the mistake widget, a new feature on the right side of the window. Allows for override and interaction in the mistake widget.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Adds a Mistake Widget that shows a list of mistakes and related information in a sidebar on the right side of the window. Additionally, allows users to override mistakes that they believe are actually correct. When a mistake is pressed, the GuitarHero window will navigate to that mistake and highlight it.
Elements to Discuss/Change
Currently, the color of the highlight for an outstanding mistake (one that hasn't been overridden) is red, while the color of an overridden mistake is green. While these colors do work for their purposes, it may be difficult to see them (as the recorded pitches are often the same colors) - as such, I'm considering changing an outstanding mistake to a white highlight.
Additionally, there are likely too many columns in the Mistake Widget as of right now - for example, Mistake # and Pair # are unnecessary together. However, I am still deciding as to which one should be removed.
Existing Code Design Notes
I had to change init_2 to have sorted times_1 and times_2 so that pairs and times would line up in the backend logic.
Additionally, changed the string editor to store mistakes so that mistake indices are stored metadata (this may not be necessary if mistake indices aren't a desired feature).
Please test! I've only tested on a couple examples, and sometimes the mistakes seem to be a bit strange/notated as the wrong type in some cases.