Repository navigation
Add support for s390x binary and image build in Github Actions - #509
Merged
Merged
Conversation
Signed-off-by: pco <pasquale.convertini@ibm.com>
Contributor
Author
|
@denyeart @bestbeforetoday could you quickly have a look to this PR and if you like it, approve it? |
adecaro
self-requested a review
July 2, 2026 12:11
|
Tick the box to add this pull request to the merge queue (same as
|
bestbeforetoday
left a comment
Member
There was a problem hiding this comment.
This change has changed the build behaviour. Provided the qemu bugs don't return and the publishing actually works, that should be fine.
Did you test publishing to the GitHub Docker registry by creating a release in your fork?
Comment on lines
-77
to
-79
| runner: | ||
| - ubuntu-22.04 # creates linux-amd64 images | ||
| - ubuntu-22.04-arm # creates linux-arm64 images |
Member
There was a problem hiding this comment.
We specifically used amd64 and arm runners rather than qemu to build natively for those target architectures because of a bug in a previous version of qemu that failed builds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This PR aims to add the
s390xplatform among the supported platforms for the Docker multiplatform image and also build thes390xbinary using GitHub Actions.With this PR, the pipeline will now generate:
linux/amd64,linux/arm64,linux/s390x,darwin/arm64,windows/amd64;linux/amd64,linux/arm64,linux/s390x.Additional details
For the images I've moved the workflow from native-VM to QEMU-emulation since GitHub Actions doesn't provide a native
s390xrunner. It follows the same approach that we use infabric-x-ordererfor the multi-platform release.The artifacts have been correctly generated using a test tag in my fork.