Skip to content

Add support for s390x binary and image build in Github Actions - #509

Merged
adecaro merged 1 commit into
hyperledger:mainfrom
pasquale95:main
Jul 2, 2026
Merged

adecaro merged 1 commit into
hyperledger:mainfrom
pasquale95:main

Conversation

@pasquale95

Copy link
Copy Markdown
Contributor

Type of change

  • Improvement (improvement to code, performance, etc)

Description

This PR aims to add the s390x platform among the supported platforms for the Docker multiplatform image and also build the s390x binary using GitHub Actions.

With this PR, the pipeline will now generate:

  • binaries: linux/amd64, linux/arm64, linux/s390x, darwin/arm64, windows/amd64;
  • image: linux/amd64, linux/arm64, linux/s390x.

Additional details

For the images I've moved the workflow from native-VM to QEMU-emulation since GitHub Actions doesn't provide a native s390x runner. It follows the same approach that we use in fabric-x-orderer for the multi-platform release.

The artifacts have been correctly generated using a test tag in my fork.

Signed-off-by: pco <pasquale.convertini@ibm.com>
@pasquale95
pasquale95 requested a review from a team as a code owner July 2, 2026 09:00
@pasquale95

Copy link
Copy Markdown
Contributor Author

@denyeart @bestbeforetoday could you quickly have a look to this PR and if you like it, approve it?

@adecaro
adecaro self-requested a review July 2, 2026 12:11

@adecaro adecaro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify

mergify Bot commented Jul 2, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@adecaro adecaro self-assigned this Jul 2, 2026
@adecaro
adecaro merged commit 9cd5f74 into hyperledger:main Jul 2, 2026
6 checks passed

@bestbeforetoday bestbeforetoday left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change has changed the build behaviour. Provided the qemu bugs don't return and the publishing actually works, that should be fine.

Did you test publishing to the GitHub Docker registry by creating a release in your fork?

Comment on lines -77 to -79
runner:
- ubuntu-22.04 # creates linux-amd64 images
- ubuntu-22.04-arm # creates linux-arm64 images

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We specifically used amd64 and arm runners rather than qemu to build natively for those target architectures because of a bug in a previous version of qemu that failed builds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants