Skip to content

split token driver in two #864#1399

Merged
adecaro merged 8 commits intomainfrom
issue-864-split-driver
Apr 23, 2026
Merged

split token driver in two #864#1399
adecaro merged 8 commits intomainfrom
issue-864-split-driver

Conversation

@adecaro
Copy link
Copy Markdown
Contributor

@adecaro adecaro commented Feb 24, 2026

This PR should make it easier to extends the validator side of a token driver.

@adecaro adecaro added this to the Q1/26 milestone Feb 24, 2026
@adecaro adecaro self-assigned this Feb 24, 2026
@adecaro adecaro marked this pull request as draft February 24, 2026 14:02
@adecaro adecaro linked an issue Feb 24, 2026 that may be closed by this pull request
@adecaro adecaro force-pushed the issue-864-split-driver branch from 34f59ac to c9a16c3 Compare February 24, 2026 15:36
@adecaro adecaro force-pushed the issue-864-split-driver branch from c9a16c3 to 5bed499 Compare March 10, 2026 08:53
@adecaro adecaro modified the milestones: Q1/26, Q2/26 Apr 2, 2026
@AkramBitar AkramBitar modified the milestones: Q2/26, Q3/26 Apr 6, 2026
@adecaro adecaro force-pushed the issue-864-split-driver branch 2 times, most recently from 77f0f8a to bfb85b5 Compare April 17, 2026 14:00
@adecaro adecaro requested a review from arner April 17, 2026 14:01
@adecaro adecaro linked an issue Apr 17, 2026 that may be closed by this pull request
@adecaro adecaro marked this pull request as ready for review April 17, 2026 14:03
Comment thread token/core/service.go
}

// NewDefaultValidator returns a new instance of driver.Validator for the passed public parameters.
// TokenDriverService is an alias for TMSDriverService for backward compatibility.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you start the comment with // DEPRECATED: , it will be clear to users (even with warnings in the editor) that the new name is preferred.

Comment thread docs/driverapi.md
@adecaro adecaro force-pushed the issue-864-split-driver branch 3 times, most recently from f06d10a to 5d9d60d Compare April 22, 2026 04:35
Copy link
Copy Markdown
Contributor

@arner arner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @adecaro

Comment thread docs/driverapi.md
@adecaro adecaro force-pushed the issue-864-split-driver branch 2 times, most recently from 806ae41 to f672e68 Compare April 23, 2026 04:50
adecaro added 5 commits April 23, 2026 08:36
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>

# Conflicts:
#	docs/driverapi.md
#	token/core/fabtoken/v1/driver/base.go
#	token/core/zkatdlog/nogh/v1/driver/base.go
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
adecaro added 3 commits April 23, 2026 08:36
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>

# Conflicts:
#	docs/driverapi.md
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
@adecaro adecaro force-pushed the issue-864-split-driver branch from f672e68 to c40e2cf Compare April 23, 2026 06:36
@adecaro adecaro merged commit d1e455c into main Apr 23, 2026
96 checks passed
@adecaro adecaro deleted the issue-864-split-driver branch April 23, 2026 07:23
sid200727 pushed a commit to sid200727/fabric-token-sdk that referenced this pull request Apr 24, 2026
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
Signed-off-by: Siddhi Khandelwal <siddhi.200727@gmail.com>
sid200727 pushed a commit to sid200727/fabric-token-sdk that referenced this pull request Apr 24, 2026
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
Signed-off-by: Siddhi Khandelwal <siddhi.200727@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

make it easier to extend an existing driver validation logic split token driver in two

3 participants