Skip to content

perf(pluto): batch-fetch keys in getAllPrismDIDs to eliminate N+1 queries #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
A-Chronicle wants to merge 1 commit into
base: main
Choose a base branch
from
+17 −23
Open

perf(pluto): batch-fetch keys in getAllPrismDIDs to eliminate N+1 queries #652

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 17 additions & 23 deletions packages/lib/sdk/src/pluto/Pluto.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,30 +483,24 @@ export class Pluto extends Domain.Startable.Controller implements Domain.Pluto {
* @returns Array of {@link Domain.PrismDID} instances.
*/
async getAllPrismDIDs(): Promise<Domain.PrismDID[]> {
const dids = await this.Repositories.DIDs.find({ method: "prism" });
const prismDIDS: Domain.PrismDID[] = [];
for (const did of dids) {
const dbDids = await this.getPrismDIDS(did.uuid);
for (const prismDID of dbDids) {
prismDIDS.push(prismDID);
}
}
return prismDIDS;
}
const allDids = await this.Repositories.DIDs.find({ method: "prism" });
const allLinks = await this.Repositories.DIDKeyLinks.getModels({
selector: { $or: allDids.map(x => ({ didId: x.uuid })) }
});
const allKeys = await this.Repositories.Keys.get({
selector: { $or: allLinks.map(x => ({ uuid: x.keyId })) }
});

private async getPrismDIDS(didId: string) {
const links = await this.Repositories.DIDKeyLinks.getModels({ selector: { didId } });
return Promise.all(
links.map(async (link) => {
const did = await this.Repositories.DIDs.byUUID(link.didId);
const key = await this.Repositories.Keys.byUUID(link.keyId);
if (!did || !key) {
throw new Error("PrismDID not found");
}
const prismDID = new Domain.PrismDID(did, key, link.alias);
return prismDID;
})
);
return allDids.flatMap(did => {
const links = allLinks.filter(x => x.didId === did.uuid);
return links
.map(link => {
const key = allKeys.find(x => x.uuid === link.keyId);
if (!key) return null;
return new Domain.PrismDID(did, key, link.alias);
})
.filter((x): x is Domain.PrismDID => x !== null);
});
}


Expand Down