Page template tests don't recognise default templates#305
Open
richplane wants to merge 1 commit intohumanmade:developfrom
Open
Page template tests don't recognise default templates#305richplane wants to merge 1 commit intohumanmade:developfrom
richplane wants to merge 1 commit intohumanmade:developfrom
Conversation
add_for_page_template() and hide_for_page_template() will now detect the use of "front-page.php" and "home.php" templates.
Author
|
If anyone else was waiting for this, here's a workaround: use ...and 'page_for_posts' works for home.php. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hide_on and show_on settings wouldn't recognise "front-page.php" and "home.php" as page-template values, because the wp_postmeta just has these as 'default'.
So I've altered the two functions show_for_page_template and hide_for_page_tempate(), which perform the test against the given template slugs. In the case where the postmeta shows "default" they now test the current post against the front page and posts page from the site options.