Update nixpkgs - #130
Merged
Merged
Conversation
All the changes (like patching up the linker path) are in the main triton derivation.
Let's try to hop on the upstream CUDA packages again. We started diverging a lot (e.g. upstream added "include" outputs to the CUDA packages) and we do not need CUDA 11.8 anymore since dropping Torch 2.7.
Sync the derivation (mostly) with nixpkgs. Use pre-compiled kernel images to speed up the build.
drbh
previously approved these changes
Nov 6, 2025
drbh
left a comment
drbh
left a comment
Collaborator
There was a problem hiding this comment.
woah haha awesome pr!
a bit hard to review but the removed files and new additions look reasonable.
LGTM pending green CI!
MekkCyber
previously approved these changes
Nov 7, 2025
MekkCyber
left a comment
MekkCyber
left a comment
There was a problem hiding this comment.
Amazing cleanup 🔥 !
What is so different about cuda 11.8 that we had to keep our own version ?
Needed for compatibility with tokenizers.
Member
Author
CUDA < 12 required a lot of additional conditionals and they were not there anymore since upstream dropped support for old CUDA versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates nixpkgs so that we can get the macOS 26 SDK in kernel-builder. As usual, there are a bunch of changes:
cudaPackagesfork. We don't have to support CUDA 11.8 anymore and our fork was diverging in terms of outputs, etc.triton-rocm, we don't need it anymore because all the fixes are upstreamed.Tested with kernel-builder (+ some changes).